WIP: Solid v2 pre-release by brenelz · Pull Request #10272 · TanStack/query

brenelz · 2026-03-14T22:06:46Z

🎯 Changes

Update solid-query to support v2 of Solid

changeset-bot · 2026-03-14T22:06:51Z

⚠️ No Changeset found

Latest commit: e7415f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-14T22:06:54Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 94eb799c-1df9-4aea-8291-0f7285ffe359

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

nx-cloud · 2026-03-14T22:08:17Z

View your CI Pipeline Execution ↗ for commit 7063f6f

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 32s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-18 19:14:32 UTC

pkg-pr-new · 2026-03-15T02:25:25Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10272

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10272

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10272

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10272

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10272

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10272

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10272

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10272

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10272

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10272

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10272

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10272

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10272

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10272

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10272

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10272

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10272

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10272

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10272

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10272

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10272

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10272

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10272

commit: 7063f6f

2wheeh · 2026-03-18T05:24:51Z

Hi, I opened a small PR against your branch brenelz#1, would you be open to this?

packages/solid-query/src/useQueries.ts

birkskyum · 2026-03-18T17:27:52Z

packages/solid-query/src/__tests__/useMutation.test.tsx

-    })
-    expect(states[2]).toMatchObject({
-      isPending: true,
-      isPaused: false,


are these test changes safe? always bit worried when fixtures get modified

yeah im not 100% sure... some needed to change to pass

packages/solid-query/src/__tests__/useMutation.test.tsx

packages/solid-query-persist-client/package.json

refactor: mv observer side effects out of memo

brenelz added 4 commits March 13, 2026 22:05

initial solid v2 convert

fd15ab1

Don to 16 failures

deb564b

fix type errors

71c8857

tests passing

3086680

github-actions bot added the package: solid-query label Mar 14, 2026

Merge branch 'main' into solid-v2-2

a5f5ea3

autofix-ci bot and others added 2 commits March 14, 2026 22:08

ci: apply automated fixes

d3b8ee8

update solid devtools and examples

2be9f52

github-actions bot added package: solid-query-persist-client package: solid-query-devtools labels Mar 15, 2026

brenelz and others added 5 commits March 14, 2026 20:43

Merge branch 'main' into solid-v2-2

3c30f69

ci: apply automated fixes

2c34c72

fixes

fbfaf67

get build to pass

853db96

ci: apply automated fixes

3912913

brenelz and others added 11 commits March 14, 2026 21:28

Fix some linting errors

bb8a3dc

ci: apply automated fixes

72d67b7

Fix build

356e12c

ci: apply automated fixes

0ea5e21

Fixes

e98a457

Fix ssr

3ef73e3

ci: apply automated fixes

c48c668

try different isServer check

4ff4427

ci: apply automated fixes

50aaa98

Get build passing more

9e8c893

tweaks

4942a15

brenelz and others added 5 commits March 15, 2026 21:35

Test passing

f6dd419

ssrSource client for now

e802447

ci: apply automated fixes

e7415f0

Merge branch 'main' into solid-v2-2

517a740

refactor: mv observer side effects out of memo

fad29d0

birkskyum reviewed Mar 18, 2026

View reviewed changes

packages/solid-query/src/useQueries.ts Show resolved Hide resolved

birkskyum reviewed Mar 18, 2026

View reviewed changes

packages/solid-query/src/__tests__/useMutation.test.tsx Show resolved Hide resolved

birkskyum reviewed Mar 18, 2026

View reviewed changes

packages/solid-query-persist-client/package.json Outdated Show resolved Hide resolved

birkskyum changed the title ~~WIP: Solid v2 2~~ WIP: Solid v2 pre-release Mar 18, 2026

brenelz and others added 6 commits March 18, 2026 13:44

Merge pull request #1 from 2wheeh/refactor/obs

11922b3

refactor: mv observer side effects out of memo

Tweaks

1381c66

Merge branch 'main' into solid-v2-2

1c4456e

ci: apply automated fixes

b3bdfe7

Fix test

07ad8be

Fix test

7063f6f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP: Solid v2 pre-release#10272

WIP: Solid v2 pre-release#10272
brenelz wants to merge 34 commits intoTanStack:mainfrom
brenelz:solid-v2-2

brenelz commented Mar 14, 2026

Uh oh!

changeset-bot bot commented Mar 14, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 14, 2026 •

edited

Loading

Review skipped

Uh oh!

nx-cloud bot commented Mar 14, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 15, 2026 •

edited

Loading

Uh oh!

2wheeh commented Mar 18, 2026

Uh oh!

Uh oh!

birkskyum Mar 18, 2026

Uh oh!

brenelz Mar 18, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

brenelz commented Mar 14, 2026

🎯 Changes

Uh oh!

changeset-bot bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

2wheeh commented Mar 18, 2026

Uh oh!

Uh oh!

birkskyum Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

brenelz Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Mar 14, 2026 •

edited

Loading

coderabbitai bot commented Mar 14, 2026 •

edited

Loading

nx-cloud bot commented Mar 14, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 15, 2026 •

edited

Loading